Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rem cx-server references from infrastructure documentation #4886

Merged
merged 11 commits into from
May 8, 2024

Conversation

1084565
Copy link
Contributor

@1084565 1084565 commented Apr 4, 2024

We deprecated the cx-server repo and image last year. These images should not be used anymore. Remaining references in the documentation need to go.

Changes

  • Tests
  • Documentation

@1084565 1084565 requested a review from a team as a code owner April 4, 2024 09:21
@1084565 1084565 requested a review from a team as a code owner April 4, 2024 09:26
@1084565 1084565 linked an issue Apr 4, 2024 that may be closed by this pull request
Copy link
Contributor

@kaylinche kaylinche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is another reference in: https://github.com/SAP/jenkins-library/blob/master/DEVELOPMENT.md?plain=1#L73

Otherwise looks fine.

Copy link
Member

@marcusholl marcusholl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beside the comment already provided by @kaylinche it looks good. That reference should also be removed before merging.

@o-liver
Copy link
Member

o-liver commented Apr 8, 2024

/it

Copy link
Member

@o-liver o-liver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Member

@tiloKo tiloKo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tiloKo
Copy link
Member

tiloKo commented May 7, 2024

/it

Copy link

sonarcloud bot commented May 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@1084565 1084565 merged commit 6456f61 into master May 8, 2024
13 of 14 checks passed
@1084565 1084565 deleted the 1084565-infra-doc branch May 8, 2024 10:51
maxatsap pushed a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024
* Rem cx-server references from infrastructure documentation

* Rem reference to cx server in plugin doc

* Rem cx-server reference from abap doc

* Rem cx-server reference from gcts cod

* Rem cx-server ref from guided tour

* Rem unused links

* Rem unused refs

* remove cx-server from development.md

---------

Co-authored-by: Oliver Feldmann <[email protected]>
Co-authored-by: tiloKo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mention deprecation of CX Server in the Documentaiton
5 participants